search

jxnblk / mdx-deck

♠️ React MDX-based presentation decks
https://mdx-deck.jxnblk.com
MIT License
11.34k stars 603 forks source link

Code Surfer! Code Surfer =[ #432

Open Relequestual opened 5 years ago

Relequestual commented 5 years ago

Hey team.

This is mostly a comment on the docs in this repo.

You link to Code Surfer, which is really cool, however it only works with mdx-deck ^1.7.7. Not mdx-deck 2 or 3. Developer is working on v2 support but can probably bump to v3.

My point is, it's a little frustrating to see a cool library but not be able to use it apart from in an old version. Could you specify that only the older version of mdx is supported?

This wouldn't be a huge problem (as far as I can tell), but export to pdf doesn't work properly, and the related issue is closed on the basis that it's fixed in v2.

I appreciate you have priorities and this might not be it, but I'm a little disheartened after my first try of using mdx-deck.

Regardless, I have to say, this is pretty awesome. Great work!

mhartington commented 5 years ago

@Relequestual Hi there! Code-surfer is currently working on their next major release which has supports for the latest version of mdx-deck

https://github.com/pomber/code-surfer/pull/58

Relequestual commented 5 years ago

Yup. Been chatting with the developer.