jxnblk / mdx-deck

♠️ React MDX-based presentation decks
https://mdx-deck.jxnblk.com
MIT License
11.33k stars 603 forks source link

Fix #738 - CodeSurfer animations briefly flashing #739

Open micheleb opened 4 years ago

micheleb commented 4 years ago

The issue I reported happens because the current page index is reset before the current step is, so CodeSurfer renders the diff between its last step and the first (hence, it displays them backwards, very quickly).

The only change I had to make was inverting the two calls at lines 92-93. All the other changes were added by prettier via the pre-commit hook.

erdemu commented 3 years ago

Accurate description and solution. Would recommend attention to this. Maybe removing all the ide changes and only doing the reordering could be better option before a merge. This way it could be easier in the future to follow code evolution. (If you blame ideally you shouldn't see anything unrelated to the fix commit itself in the history)