search

jxnblk / plangular

Create custom SoundCloud players with HTML & CSS
http://jxnblk.github.io/plangular
480 stars 93 forks source link

Parse API responses pre-processed externally #29

Closed mrbrainz closed 9 years ago

mrbrainz commented 10 years ago

Love Plangular. Used it in a webapp I'm working on. The app uses Soundcloud's PHP API Wrapper to pull data from tracks. That means I'm essentially doubling the number of calls I'm making to the API by passing the permalink to Plangular when I could just straight pass meta that I've already pulled over cURL.

Your code is a doozy, and my lack of knowledge of how Vuejs works meant it blew my mind and I couldn't hack my way around the source to pass the Stream_URL.

Can you add some sort of support for external data sources being passed to the player to reduce calls to the API?

Cheers,

Greg

jxnblk commented 10 years ago

Generally I like this idea. Were you imagining just a more generic player that only accepts a stream_url or still something that uses the entire track object for templating?

mrbrainz commented 10 years ago

Well I guess that you'd have to pass more than just the Stream URL to get it working properly with things like the duration, right?

I guess for my own personal uses, I'd need a seekable player (maybe with the waveform passed in somehow) and the duration of the track as it plays. But to supercharge it, your idea of sending the entire object for templating would work well. It could make your source code look a little more chaotic than it needs to though.

jxnblk commented 9 years ago

Closing this out as I don't plan on adding support for this in Plangular. (May implement something similar in a separate repo)