search

jxom / bumbag-ui

Build themeable React & React Native applications with your Bumbag 👝
https://bumbag.style
MIT License
1.01k stars 50 forks source link

Upgrade emotion #109

Closed Chrischuck closed 3 years ago

Chrischuck commented 3 years ago

v10 -> v11

Now works out of box w/ Next.js; no need to add anything in _document.js

To test, make sure you yarn link bumbag-server and gatsby-plugin-bumbag

jxom commented 3 years ago

Looking amazing @Chrischuck! Just another few comments and hopefully we can get this merged.

Chrischuck commented 3 years ago

Thanks @jxom! which comments are left? and can you take a look at the screenshot I posted of the model snapshot, wondering if you could point me in the direction of what needs fixing for it

jxom commented 3 years ago

Thanks!

The failing Modal test seemed to be because of a className={undefined} prop that was added to the backdrop. I have fixed it now though.