Component style reset by bb-Box when NODE_ENV=production

jxom / bumbag-ui

Build themeable React & React Native applications with your Bumbag 👝

https://bumbag.style

MIT License

1.01k stars 50 forks source link

Component style reset by bb-Box when NODE_ENV=production #113

Closed sam-chuang closed 3 years ago

sam-chuang commented 3 years ago

Component style reset by bb-Box when NODE_ENV=production

After this change, the order of bb-Box moved to the bottom, according to this, it reset components' style

Refer to the repo

Go to this link
The style of the button got reset by bb-Box

Expected behavior Button's style should based on bb-Box, not reset by bb-Box

Screenshots button

Device information (please complete the following information):

Device:
OS, version: Win 10
Browser, version: Chrome 89

jxom commented 3 years ago

Hmm, that's annoying! After our upgrade to Emotion 11, it seemed to have messed up the precedence of the inherited Box styles. However, it looks like here that the change I made to move the reset styles to the global styles doesn't seem to work. Let me have a look into it.

jxom commented 3 years ago

This should be fixed in 1.11.5

sam-chuang commented 3 years ago

Thanks for the fix!!