Bumbag cannot be run without Cookies Enabled

jxom / bumbag-ui

Build themeable React & React Native applications with your Bumbag 👝

https://bumbag.style

MIT License

1.01k stars 50 forks source link

Bumbag cannot be run without Cookies Enabled #158

Closed benedictong-localz closed 3 years ago

benedictong-localz commented 3 years ago

Describe the bug

If you are using bumbag in an iframe in incognito mode (which by default disables cookies from third parties) it crashes. I believe this is because one of the dependencies uses localStorage.

To Reproduce

Disable cookies
go to the bumbag.style website :D

jxom commented 3 years ago

Can you try disable local storage in this context?

https://www.bumbag.style/docs/color-modes#disabling-local-storage

jxom commented 3 years ago

Ideal scenario is that we modify Bumbag to check to see if Storage is available before we use local storage. I am open to PRs for this. Hacktoberfest coming up!

benedictong-localz commented 3 years ago

interesting! That could work, i'll give it a go and report back

benedictong-localz commented 3 years ago

Worked perfectly! thanks @jxom

jxom commented 3 years ago

🤝🤝🤝🤝🤝🤝🤝🤝🤝🤝🤝🤝🤝🤝