Try to apply mode styles to root html element before body

jxom / bumbag-ui

Build themeable React & React Native applications with your Bumbag 👝

https://bumbag.style

MIT License

1.01k stars 50 forks source link

Try to apply mode styles to root html element before body #162

Closed daveols closed 2 years ago

daveols commented 2 years ago

The background colour from custom modes wasn't being correctly applied to pages that had a body smaller than the view height.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

bumbag-ui – ./

🔍 Inspect: https://vercel.com/jxom/bumbag-ui/JAS1nQBZG2vUWvdx8RXS6Cj5gK5S
✅ Preview: https://bumbag-ui-git-fork-daveols-apply-mode-styles-to-root-jxom.vercel.app

jxom commented 2 years ago

Bumbag docs seem broken in dark mode. We may need to amend the following to just 'html': https://github.com/jxom/bumbag-ui/blob/main/packages/bumbag/src/theme/index.ts#L26