search

jxom / bumbag-ui

Build themeable React & React Native applications with your Bumbag 👝
https://bumbag.style
MIT License
1.01k stars 50 forks source link

fix: column spread prop type #228

Closed joshuafsharp closed 2 years ago

joshuafsharp commented 2 years ago

When calculating the width for a column using the spread prop, the value is divided by 12 and set to the percentage of the result:

https://github.com/jxom/bumbag-ui/blob/main/packages/bumbag/src/Columns/Columns.styles.ts#L62

The type for the prop only allows values 1-12, but float values are also applicable for the prop. This PR generalises the type to allow any number to be passed.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
bumbag-ui ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 2:03AM (UTC)