Closed danielagattoni closed 4 years ago
✅ This PR (commit SHA 7423339) successfully built (bundle ID 463411bdb) VIEW LOGS
🌏 Permanent preview links of latest version on this branch: EDIT
https://fannypack--develop--fixinput-with-data-testid.branch.linc-preview.sh/ https://fannypack--production--fixinput-with-data-testid.branch.linc-preview.sh/
🌏 Preview links for bundle 463411bdb / commit 7423339: EDIT
https://fannypack--463411bdb--develop.linc-preview.sh https://fannypack--463411bdb--production.linc-preview.sh
I think this is more of a Reakit responsibility rather than Fannypack. If we add data-*
attributes to only Input & Select, then we should make every component compatible with them.
<Input />
and<Select />
components with a custom type definition fordata-testid
data attribute.before: typescript errors
after: no erros.
cc: @jxom