jxom / fannypack

[UNMAINTAINED] An accessible-focused, themeable, friendly React UI Kit.
https://fannypack.style
MIT License
235 stars 29 forks source link

fix: adds data-testid into inputProps for Input and Select components #100

Closed danielagattoni closed 4 years ago

danielagattoni commented 4 years ago

before: typescript errors

Screen Shot 2019-12-05 at 8 59 25 pm

after: no erros.

Screen Shot 2019-12-05 at 9 00 11 pm

cc: @jxom

linc[bot] commented 4 years ago

Preview releases deployed with Linc logo Linc

✅ This PR (commit SHA 7423339) successfully built (bundle ID 463411bdb)  VIEW LOGS

🌏 Permanent preview links of latest version on this branch:  EDIT

https://fannypack--develop--fixinput-with-data-testid.branch.linc-preview.sh/
https://fannypack--production--fixinput-with-data-testid.branch.linc-preview.sh/

🌏 Preview links for bundle 463411bdb / commit 7423339:  EDIT

https://fannypack--463411bdb--develop.linc-preview.sh
https://fannypack--463411bdb--production.linc-preview.sh
jxom commented 4 years ago

I think this is more of a Reakit responsibility rather than Fannypack. If we add data-* attributes to only Input & Select, then we should make every component compatible with them.