search

jxom / fannypack

[UNMAINTAINED] An accessible-focused, themeable, friendly React UI Kit.
https://fannypack.style
MIT License
235 stars 29 forks source link

Styling/theming of Select and SelectMenu #51

Open hastebrot opened 5 years ago

hastebrot commented 5 years ago

The icon of Select components can't be changed.

screenshot 2019-02-19 at 13 27 47

The Select component of a SelectMenu ignores theme configuration.

screenshot 2019-02-19 at 13 28 13
hastebrot commented 5 years ago

My plan is to allow replacement of <Icon /> via a new prop.

// Select.tsx
{isLoading ? <LoadingSpinner color="text" /> : <Icon />}

Maybe there should also be an icon property in the Select theme options.

Same applied to SelectMenu:

// SelectMenu.tsx
{isLoading ? <SelectMenuLoadingSpinner color="text" /> : <SelectIcon />}

Additionally SelectMenu should be themed using SelectMenu.Select theme option or Select theme option.