nus-pe-bot
commented
3 years ago Team's Response
Error shown is still valid. Tester just suggests we add in another error in the case that someone inputs a negative identifier by accident. This is a suggestion, not a bug.
In the tester's use case, he inputs '-' which is registered as a string character and falls into the second case pointed out by the error.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: Not answering the question. The main question is: Why is the error message indicating that the identifier accepts negative values? The screenshot of input "-" was just an example. Try it out with 0 or any negative values. Your counter argument might be that "there is another error message which will tell you that you can only put positive values".
Hence my question, why would you put the user through multiple cycles of error messages when you can only do it in 1? Yes, you are closing down to your supposed "subset" of valid values, would it then make sense if you go ahead and do 100 of such subsets to bring the user through unnecessary rounds of error messages? Come on, this is just a low severity issue and you know it is an issue. Why not just be gracious enough to accept it?
:question: Issue severity
Team chose [severity.Low]
Originally [severity.High]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
jxrrelo
Error message says valid identifiers should be between MIN_INT and MAX_INT but how can identifiers be negative value?? I understand if we attempt to put negative values it will say it should be positive. That doesn't these 2 error messages conflict each other?