Proper commands handling ('/help' and others)

maximyurchuk commented 4 years ago

There are were some problems at least with current steam client (0.7.5):

player can't use /help because it declared with 's' specifier. TW client rejects sending /help message because it expects string argument;
case /help someting was handled incorrectly. Instead of printing help info about 'something' actual behaviour was printing something in common chat. It's happened because then calling OnChatMessage(ID, 0, ID, pArgs); pArgs doesn't prefixed with /help ;
also /rank command was not recognized as command in TW client (then you press / in chat you can view list of commands) because in modern TW client there is no 'p' (player) specifier. It was removed in this commit.

You can check these problems in game.

This pull request have following changes:

greeting message don't use OnChatMessage anymore (it was quite strange);
all commands registred in CommandsManager() now, so it visible in TW client (release and allmessages were added);
handling commands was moved into OnPlayerCommandImpl;
all specifiers for commands are removed;

-- bleeding

maximyurchuk commented 4 years ago

Argh, seems 0.7.4 commands are broken with this change.

jxsl13 commented 4 years ago

will merge when 0.7.6 is released and most people play >= 0.7.5 then

maximyurchuk commented 4 years ago

@jxsl13 I fixed problems with clients 0.7.4 and below, so, I suppose it can be merged without waiting 0.7.6 release. For fix details see my last commit.

jxsl13 commented 4 years ago

original source: https://github.com/jxsl13/zcatch/blob/7fb4e63cd4b4ba9649326e90af615d15b9b576ad/src/game/server/gamemodes/zcatch.cpp#L318

this PR breaks the /rank nickname with spaces

maximyurchuk commented 4 years ago

Yeah, already realize that. Fixed in last commit.

jxsl13 / zcatch

Proper commands handling ('/help' and others) #82