jyawn / googletransitdatafeed

Automatically exported from code.google.com/p/googletransitdatafeed
0 stars 0 forks source link

Feed Validator should send a warning when there are multiple consecutive 0:00:00 stop_times #296

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
From a user of Feed Validator:

Today I stumbled over a feed that validated but had all arrival and departure 
times set to "0:00:00".  I expected to see at least TooFastTravel warnings but 
there weren't any.  As far as I know this is because of a default duration of 1 
minute that is set if the next stop's arrival time equals the previous stop's 
departure time?  Maybe it makes even sense to warn if any time value repeats 
multiple times and not only look at 0:00:00 values?

To address this, I propose checking for consecutive stop times that have not 
changed.  If four or more consecutive stop times have the same arrival and 
departure times, we flag an error.  The decision to use 4+ as a threshold was 
somewhat arbitrary, but I have tested the validation code against the Google 
Transit corpus and not found any feeds where this threshold caused an issue.

Original issue reported on code.google.com by bdfer...@google.com on 19 Sep 2011 at 9:58

GoogleCodeExporter commented 8 years ago
Committed in r1589.  See review at http://codereview.appspot.com/5131049/

Original comment by bdfer...@google.com on 4 Oct 2011 at 10:49

GoogleCodeExporter commented 8 years ago

Original comment by bdfer...@google.com on 24 Oct 2011 at 9:38