search

jyawn / googletransitdatafeed

Automatically exported from code.google.com/p/googletransitdatafeed
0 stars 0 forks source link

Validator trips.txt files are invalid #332

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Run java/Transxchange2GoogleTransit/validator.sh
2. Notice that trips.txt differ
3. Examine ValidatorFiles/val1/trips.txt and 
ValidatorFiles/ref1/20040922/trips.txt (and for val2 and ref2, val3 and ref3). 
Note how the reference trips.txt are invalid as they have more columns than 
they should as they are not correctly quoted. Note how the 
 current values are more correct as they are correctly quoted.

What is the expected output?
Files ValidatorFiles/val1/trips.txt and ValidatorFiles/ref1/20040922/trips.txt 
are identical
Files ValidatorFiles/val2/trips.txt and ValidatorFiles/ref2/20040922/trips.txt 
are identical
Files ValidatorFiles/val3/trips.txt and ValidatorFiles/ref3/20040301/trips.txt 
are identical
What do you see instead?
Files ValidatorFiles/val1/trips.txt and ValidatorFiles/ref1/20040922/trips.txt 
differ
Files ValidatorFiles/val2/trips.txt and ValidatorFiles/ref2/20040922/trips.txt 
differ
Files ValidatorFiles/val3/trips.txt and ValidatorFiles/ref3/20040301/trips.txt 
differ

What version of the product are you using? On what operating system?
I am using trunk with a few patches applied, the most recent revision I have is 
1671. I haven't made any changes to the files which are incorrect.
$ uname -a
Linux grapevine.cl.cam.ac.uk 2.6.38-15-generic #60-Ubuntu SMP Tue May 22 
11:28:40 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 11.04
Release:    11.04
Codename:   natty

Please provide any additional information below.

This has probably been the case for a while, I attach a patch to alter 
validate.sh so that it doesn't produce output for files which are the same as 
this way the files which are different become much more visible.

Original issue reported on code.google.com by scottish...@googlemail.com on 8 Jun 2012 at 9:43

Attachments:

GoogleCodeExporter commented 8 years ago 
Attaching a patch to fix the reference files to have valid csv and a patch to 
make sure that trailing whitespace is not left on route descriptions so that it 
doesn't end up in the csv.

Original comment by scottish...@googlemail.com on 8 Jun 2012 at 9:54

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by bdfer...@google.com on 26 Sep 2014 at 4:30