search

jyby / repositorium

Document bootstrapping database with collective quality control
4 stars 5 forks source link

SETUP Validation of Tag length #3

Open hfierro opened 13 years ago

hfierro commented 13 years ago

A server error is thrown and shown when sending documents with long tags.

Solutions:

  1. Tag lenght should be allowed larger
  2. Tag length is not beign validated in client side.
mquezada commented 13 years ago
  1. Changing the SQL code to allow larger tags should be ok.
  2. In the validate var (https://github.com/mquezadav/repositorium/blob/master/app/models/tag.php) should be enough to restrict the max length of a tag. I don't think it is necessary to validate each input on client side, because it's still in prototype stage.
  3. It occurs because of the missing validation on the model side (see 2).