search

jychoi118 / P2-weighting

CVPR 2022
MIT License
143 stars 14 forks source link

SNR value #16

Open LuigiSigillo opened 1 year ago

LuigiSigillo commented 1 year ago

In the paper in equation (4) you give a formulation of the SNR, but then in the code you use another formulation for this value. Which is the correct one?

jychoi118 commented 1 year ago

Sorry for the confusion. Actually, equation 4 and the code are equivalent: 1.0 / (1 - alpha) - 1 = alpha / (1 - alpha).

LuigiSigillo commented 1 year ago

Thanks you for the quick answer! You are right, totally an oversight from my side 😅.