`result` is redundant and can be removed - Githubissues

jycouet / VSTSExtensions

MIT License

30 stars 11 forks source link

`result` is redundant and can be removed #3

Closed DavidParks8 closed 6 years ago

DavidParks8 commented 6 years ago

No matter what occurs, result is set to 1. Additionally, it is never used outside of the exec function, so it is not necessary. https://github.com/jycouet/VSTSExtensions/blob/a9c523d590713a96d540f66792429e52a2fdb63b/renovateMe/buildtask/src/index.ts#L42

jycouet commented 6 years ago

Fixed with commit: https://github.com/jycouet/VSTSExtensions/commit/9924fdf2e36c97a5321ad873486a465f357f143e

I think it's better like this