jycouet / VSTSExtensions

MIT License
30 stars 11 forks source link

Renovate log level input #40

Closed viceice closed 3 years ago

viceice commented 3 years ago

Is your feature request related to a problem? Please describe. If you enable renovate log level via config or cli it will miss some important messages.

Describe the solution you'd like Please add an input to simply allow renovate log level config via environment. Renovate will parse LOG_LEVEL env very early, so no log messages are missing.

Describe alternatives you've considered no alternate

Additional context ref #39

viceice commented 3 years ago

Additional env can be passed as third parameter to tasklib.exec

https://github.com/jycouet/VSTSExtensions/blob/9b796c42a470c6f3bb299f959f40fea3a9d89412/renovateMe/buildtask/src/index.ts#L54

eg:

await taskLib.exec(options!.tool, options!.arguments, { env: { LOG_LEVEL: logLevel} });

ref:

jycouet commented 3 years ago

Isn't it possible to put this in arguments already?

viceice commented 3 years ago

Sure, but them some important debug messages are missing which are very helpful to debug config issues.

The commandline args are parsed to late, so we will miss those messages

viceice commented 3 years ago

logLevel option is now deprecated: renovatebot/renovate#8291

jycouet commented 3 years ago

It seems that I have to do an update ;)

jycouet commented 3 years ago

Actually, as now it's recommended to use environment variable, I suggest that you do this setting like this: image