jycouet / VSTSExtensions

MIT License
30 stars 11 forks source link

Update renovate extension to support node version 6 #68

Closed SebastianSchuetze closed 4 months ago

SebastianSchuetze commented 7 months ago

Describe the bug You task in the task.json in the execution property is only supporting node 6 by using "Node". You should only support "Node10" or "Node16".

To Reproduce Run a pipeline with an agent which does not support node 6

Expected behavior support node 10 or 16

Additional context Microsoft is depricating node 6 and should support node 16 or at least node 10

jycouet commented 7 months ago

Hi there, Could you make a PR ?

ttothea commented 7 months ago

Hi jycouet,

i've created a pr for your review.

Regards

jycouet commented 7 months ago

🙏 thx https://github.com/jycouet/VSTSExtensions/pull/69

I'll try to upload it now

jycouet commented 7 months ago

🤔 not that easy...

I get this when I try to build.

TFS Cross Platform Command Line Interface v0.10.0
Copyright Microsoft Corporation
error: Error: EISDIR: illegal operation on a directory, read
 ELIFECYCLE  Command failed with exit code 255.

(I'm on MAC now)

You manage to build on your side? (You can send it maybe?)

Are you interested to own the repo & package? :)

ttothea commented 7 months ago

hej, thanks for reaching out!. I'm a bit tied up at the moment and won't be able to test the code right now. I will keep this in my mind and will do my best to circle back at it later. Appreciate your understanding!