jycouet / VSTSExtensions

MIT License
30 stars 11 forks source link

Failure on windows agent since latest version #76

Open rkg-mm opened 2 months ago

rkg-mm commented 2 months ago

Describe the bug We were running this extension previously on a windows agent without any issues. However, since one of the last updates it failed to work with following error:

==============================================================================
Task         : Renovate Me
Description  : Renovate your libs on your selected Azure Repo
Version      : 1.0.5
Author       : Jean-Yves COUET
Help         : [Renovate Me](https://marketplace.visualstudio.com/items?itemName=jyc.vsts-extensions-renovate-me) based on [renovate](https://github.com/singapore/renovate)
==============================================================================
##[error]A supported task execution handler was not found. The task does not carry an implementation that is compatible with your current operating system 'Windows(X64)'. Contact the task author for more details.

Few days before it still succeeded with this version:

==============================================================================
Task         : Renovate Me
Description  : Renovate your libs on your selected VSTS repo
Version      : 1.0.1
Author       : Jean-Yves COUET
Help         : [Renovate Me](https://marketplace.visualstudio.com/items?itemName=jyc.vsts-extensions-renovate-me) based on [renovate](https://github.com/singapore/renovate)
==============================================================================

Any idea if you can solve this?

To Reproduce Steps to reproduce the behavior: Run latest version on a windows x64 agent

Expected behavior Since renovate itself should be working on windows, I would hope this extension can also support it.

jycouet commented 2 months ago

Hummm, I have no idea of what could cause the issue 🤔 Maybe @Polymeta or @KaVeKa have a guess?

KaVeKa commented 2 months ago

Not sure here either. All that was changed is inside the typescript code itself. Maybe the renovate validation step itself does not run on windows x64?

Polymeta commented 2 months ago

Not sure here either. All that was changed is inside the typescript code itself. Maybe the renovate validation step itself does not run on windows x64?

If you mean the actual npx config validation command from renovate I can confirm it does work quite well on windows machines, so I doubt that's an issue.

A shot in the dark maybe, but what's your agent version? Mine is 3.236.1 for reference.

rkg-mm commented 2 months ago

Yes renovate itself should work fine on windows.

The pipeline is running on agent version 2.181.2 (customer provided so I have no control over that) however, the failing as well as the successful run both were on the same agent version. Only difference I can spot is the extension version as shown above.

rkg-mm commented 2 months ago

I have no experience in Extension creation, but the error message in google popped up another plugin with this error and a reference as cause to https://devblogs.microsoft.com/devops/node-runner-update-guidance-for-azure-pipelines-task-authors/ could that help?

edit: in both runs i have an install Node 18 task before running renovate. no change from our side

Polymeta commented 2 months ago

Yes renovate itself should work fine on windows.

The pipeline is running on agent version 2.181.2 (customer provided so I have no control over that) however, the failing as well as the successful run both were on the same agent version. Only difference I can spot is the extension version as shown above.

Thanks for clarifying and yeah I was just about to lead up to that too. I have reason to believe that the migration to node 16 was not fully carried out potentially.

Please review this https://github.com/microsoft/azure-pipelines-tasks/blob/master/docs/migrateNode16.md - it lists a bunch of steps for task authors to do, including bumping some package version numbers, which has not been done for RenovateMe, thus could possibly cause theses issues

rkg-mm commented 2 months ago

@jycouet any chance you can fix this?

jycouet commented 2 months ago

Hi @rkg-mm and thx @Polymeta & @KaVeKa for the support.

I have an issue, I don't use Azure for several years now, so, for each changes, to be honest: "I'm blind!". Is someone interested in owning this extension? I'll be happy to give it to someone who actually use it ✌️. (or deprecate it and redirect to one of yours?)


Regarding the fix, yes, there is probably something to check with the node version. I don't have much time RN (and can't test anything anyway :/ )