search

jyksnw / install-jdk

install-jdk is a Python library for easily installing the latest OpenJDK for a given major version. Supports builds from Adoptium and Corretto. Simplify your Java development with the latest OpenJDK builds.
https://pypi.org/project/install-jdk/
MIT License
16 stars 2 forks source link

Pass to adoptium #15

Closed LvffY closed 1 year ago

LvffY commented 2 years ago

It seems that the current URL api.adoptopenjdk.net is deprecated (see home page), and that the URL should be changed to api.adoptium.net.

There is a migration guide that could be follow.

LvffY commented 2 years ago

If I'm right, the line to change should be https://github.com/jyksnw/install-jdk/blob/b45f5bf8260812e2bcc8727c5ff297cad952a6c6/jdk/__init__.py#L56

LvffY commented 2 years ago

@jyksnw did you have time to check on this ?

jyksnw commented 2 years ago

Hi @LvffY, I am short on time these days to maintain this repository. Feel free to fork it or put in a PR to resolve this issue. Otherwise, I will look at the changes within the next month to determine what needs to be updated.

jyksnw commented 1 year ago

Just an update on this - I will be dedicating time over the next weeks and months to bring new life to this project, where the priority will be updated to use the Adoptium.

jyksnw commented 1 year ago

@LvffY I have updated the main branch to switch away from AdoptOpenJDK and have elected to use a pluggable client system that allows the end user to select which build implementation to choose from. Adoptium is now the default, and I have the option to switch to using Corretto. I did make some substantial code changes behind the scenes but left the primary client API intact to be backward compatible with prior releases. Because of this, I will be testing this out before pushing it up to PyPI.

I would love for others to checkout the main branch and do some additional real-world testing.

jyksnw commented 1 year ago

Adoptium support has been added and will be available in the 1.x release due out around the first week of March.