search

jyn514 / GradeForge

Courses available from my.sc.edu
GNU General Public License v3.0
1 stars 0 forks source link

instructor names might not be unique #18

Closed jyn514 closed 6 years ago

jyn514 commented 6 years ago

the sql database originally had instructor emails as the primary key. the reasoning for this was that all instructors have different emails, but some might have the same names. unfortunately, not all instructors have an email (or at least it isn't shown). this means that there may not be a unique combo of name and email for each instructor.

there's no solution for this, we just have to keep it in the background and hope they don't, in fact, share names.

jyn514 commented 6 years ago

I forgot that there can be multiple instructors for a class. Not sure how to handle this - the email can vary depending on section, so maybe the primary email should be a property of the section? But then how do we store multiple instructors, have a linking table? That'd be messy and annoying.

jyn514 commented 6 years ago

https://github.com/jyn514/GradeForge/commit/3e75a5644a756fecd9ffeb9d344d59433939062a uses two columns, one for primary instructor and one for secondary instructors (which is usually blank). I'm comfortable enough with the accuracy to close this. @JamesPC44 will likely still want to separate the instructors into a separate linking table, though; currently they're in CSV format within the SQL database