Continuous Integration - Githubissues

jyn514 / threaded-server

A stupid simple server with threading

BSD 3-Clause "New" or "Revised" License

10 stars 4 forks source link

Continuous Integration #22

Open justinba1010 opened 5 years ago

justinba1010 commented 5 years ago

Going to make this a meta issue - Joshua

Check the server

[ ] compiles (make)
[ ] works (make test)
[ ] is memory safe (make valgrind). It would be wonderful it this were a part of make test in the future.
[ ] is reasonably performant under heavy load

Original comment:

I can go ahead and set up some unit tests with TravisCI or CircleCI(I'm more experienced with CI), if you'd like to add some continuous integration to this project.  - Justin

jyn514 commented 5 years ago

Is circleci free?

That would be great, thanks! You should be able to run make test, if that exits with 0 the build succeeded.

justinba1010 commented 5 years ago

Ya, I'll try and get that up and running. It is free for up to 1000 build minutes. I'll try to make it so only PRs get the CI.

justinba1010 commented 5 years ago

Is there any target we should be aiming for?

jyn514 commented 5 years ago

1000 per month, got it. Not sure what you mean by target, but if you run make test all the tests will run.

If you want to add CI for master that would be great as well.

justinba1010 commented 5 years ago

Like what OS to test on.

jyn514 commented 5 years ago

Oh! Yes I'd like to test OSX, FreeBSD, and Ubuntu 18.04.

jyn514 commented 5 years ago

I started working on this in the cirrusci branch, I chose them because

docker is reproducible
they support BSD, which CircleCI doesn't
they have free builds for open source

Will update this later today, I have unpushed changes.