search

jyotirmaybanerjee / react-duallist

A React searchable and sortable and fully customizable dual list. It supports custom icons.
https://rawgit.com/jyotirmaybanerjee/react-duallist/master/example/examples.html
MIT License
6 stars 5 forks source link

Can't override/localise the search placeholder text #3

Closed DLatheron closed 6 years ago

DLatheron commented 6 years ago

The string for the placeholder test for the left and right search boxes appears to be fixed in Index.js, lines 235 and 294.

It would be really useful to make this externally accessible because currently a library user can change the props for the left and right labels, but can't keep the search text in sync with these names.

I'm happy to submit a PR for the change if you don't have time.

jyotirmaybanerjee commented 6 years ago

@DLatheron Please feel free to create the PR. I'll be happy to merge that.

DLatheron commented 6 years ago

Cheers!

I've got the change on a local branch, but I don't have permissions to create a branch (and therefore a PR) in your repository. How do you want to do this?

DLatheron commented 6 years ago

@jyotirmaybanerjee I have merged this - can you push the latest to NPM please?

DLatheron commented 6 years ago

Fix made - but needs to be published :-)

jyotirmaybanerjee commented 6 years ago

Done. :)

DLatheron commented 6 years ago

Cheers!

Sent from my iPhone

On 4 Oct 2018, at 17:57, Jyotirmay Banerjee notifications@github.com wrote:

Done. :)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.