search

jyotisham / jyotisha

Python tools for the astronomical / astrological vedAnga of Hindus
MIT License
88 stars 52 forks source link

Tests failing #111

Closed karthikraman closed 3 years ago

karthikraman commented 3 years ago

Really not sure what's the issue. Wonder if some dependency is outdated, locally. I have updated test data and re-uploaded too.

astrorigin commented 3 years ago

Maybe related to these recent changes: https://github.com/astrorigin/pyswisseph/commit/95faca0aea5147b426639938a9db727b348f76a7

Like use of swe.sol_eclipse_when_loc(), swe.lun_eclipse_when_loc() in jyotisha/panchaanga/spatio_temporal/__init__.py

Previously returned 3 tuples like: (i)(dddddddddd)(dddddddddd) Now returning: i(dddddddddd)(dddddddddd)

vvasuki commented 3 years ago

Thanks, @astrorigin . The upstream changes caused minute fractional changes in the results, breaking tests. Have now (mostly) made them more robust.

This then results in 1 second changes in tex files produced - I don't see any easy way to make those text-comparison tests more robust. Perhaps some regex replacement to blank away seconds?

astrorigin commented 3 years ago

I see, those fractional changes were probably caused by https://github.com/astrorigin/pyswisseph/commit/7014e10c5d0249e882c0d15e5ad756b8eb0651f0