search

jyotisham / jyotisha

Python tools for the astronomical / astrological vedAnga of Hindus
MIT License
88 stars 52 forks source link

suggestions for improving city.get_lunar_eclipse_time #113

Open karthikraman opened 3 years ago

karthikraman commented 3 years ago

Instead of the (obscure) tuple that swisseph returns, what other data structure could be returned? a dict with start, end times of umbral, penumbral eclipses and moonrise/moonset @vvasuki ?

vvasuki commented 3 years ago

Prefer a newly defined EclipseTime object to a dict (if returning info about a single eclipse, as I gather from the name of the method). I don't see why it should contain moonrise/ moonset times.