jyotisham / jyotisha

Python tools for the astronomical / astrological vedAnga of Hindus
MIT License
92 stars 54 forks source link

Freezing phswisseph version. #114

Closed vvasuki closed 5 months ago

vvasuki commented 3 years ago

Considering https://github.com/jyotisham/jyotisha/runs/3331564224?check_suite_focus=true , I've frozen pyswisseph version expected. Please fix your dev machine environment as needed @karthikraman and close this issue.

astrorigin commented 3 years ago

Sorry for the small API changes (quick and easy to fix...) but v2.8.0-1 has some creeping bugs anyway. Currently a huge effort towards comprehensive documentation. And later will setup a test suite, so testers and contributers needed, please hit me up if you feel like giving a hand. All that should lead us to a high-quality, and more stable module.

vvasuki commented 3 years ago

Great to hear about the proposed changes and continuing maintenance! I don't begrudge the small api changes - it's just downstream users like us should be using a fixed version of the library (which was not possible earlier for some feature we needed). Once there's a new version on pypi, it would be great if you let us know somehow.

vvasuki commented 5 months ago

Dang - old trusty frozen version no longer installs -

$ ~/gitland/python_venv_311/bin/pip install pyswisseph==2.8.0.post1
Collecting pyswisseph==2.8.0.post1
  Using cached pyswisseph-2.08.00-1.tar.gz (521 kB)
  Preparing metadata (setup.py) ... done
Building wheels for collected packages: pyswisseph
  Building wheel for pyswisseph (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py bdist_wheel did not run successfully.
  │ exit code: 1
  ╰─> [81 lines of output]
      Searching system libswe...
      pkg-config not found
      Using internal libswe
      /home/vvasuki/gitland/python_venv_311/lib/python3.11/site-packages/setuptools/dist.py:320: InformationOnly: Normalizing '2.08.00-1' to '2.8.0.post1'
        self.metadata.version = self._normalize_version(
      libswe/swecl.c: In function ‘swe_rise_trans_true_hor’:
      libswe/swecl.c:4444:11: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
       4444 |           if (!do_fixstar)
            |           ^~
      libswe/swecl.c:4447:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
       4447 |             if (rsmi & SE_BIT_GEOCTR_NO_ECL_LAT)
            |             ^~
      libswe/swehel.c: In function ‘calc_rise_and_set’:
      libswe/swehel.c:478:1: warning: this ‘else’ clause does not guard... [-Wmisleading-indentation]
        478 | else
            | ^~~~
      libswe/swehel.c:484:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘else’
        484 |   iflag = epheflag|SEFLG_SPEED|SEFLG_EQUATORIAL;
            |   ^~~~~
      libswe/sweph.c: In function ‘search_star_in_list’:
      libswe/sweph.c:6534:20: warning: comparison of integer expressions of different signedness: ‘long int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
       6534 |     if (sp - sstar != strlen(sstar) - 1) {
            |                    ^~
      libswe/swephlib.c: In function ‘swi_strnlen’:
      libswe/swephlib.c:3598:17: warning: operand of ‘?:’ changes signedness from ‘long int’ to ‘size_t’ {aka ‘long unsigned int’} due to unsignedness of other operand [-Wsign-compare]
       3598 |   return stop ? stop - str : n;
            |                 ^~~~~~~~~~
      libswe/swephlib.c: In function ‘swe_get_astro_models’:
      libswe/swephlib.c:4271:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
       4271 |         if (imod == SEMOD_PREC_DEFAULT) imod = 0; break;
            |         ^~
      libswe/swephlib.c:4271:51: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
       4271 |         if (imod == SEMOD_PREC_DEFAULT) imod = 0; break;
            |                                                   ^~~~~
      libswe/swephlib.c:4273:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
       4273 |         if (imod == SEMOD_PREC_DEFAULT_SHORT) imod = 0; break;
            |         ^~
      libswe/swephlib.c:4273:57: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
       4273 |         if (imod == SEMOD_PREC_DEFAULT_SHORT) imod = 0; break;
            |                                                         ^~~~~
      libswe/swephlib.c:4275:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
       4275 |         if (imod == SEMOD_NUT_DEFAULT) imod = 0; break;
            |         ^~
      libswe/swephlib.c:4275:50: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
       4275 |         if (imod == SEMOD_NUT_DEFAULT) imod = 0; break;
            |                                                  ^~~~~
      libswe/swephlib.c:4277:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
       4277 |         if (imod == SEMOD_SIDT_DEFAULT) imod = 0; break;
            |         ^~
      libswe/swephlib.c:4277:51: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
       4277 |         if (imod == SEMOD_SIDT_DEFAULT) imod = 0; break;
            |                                                   ^~~~~
      libswe/swephlib.c:4279:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
       4279 |         if (imod == SEMOD_BIAS_DEFAULT) imod = 0; break;
            |         ^~
      libswe/swephlib.c:4279:51: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
       4279 |         if (imod == SEMOD_BIAS_DEFAULT) imod = 0; break;
            |                                                   ^~~~~
      libswe/swephlib.c:4281:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
       4281 |         if (imod == SEMOD_JPLHOR_DEFAULT) imod = 0; break;
            |         ^~
      libswe/swephlib.c:4281:53: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
       4281 |         if (imod == SEMOD_JPLHOR_DEFAULT) imod = 0; break;
            |                                                     ^~~~~
      libswe/swephlib.c:4283:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
       4283 |         if (imod == SEMOD_JPLHORA_DEFAULT) imod = 0; break;
            |         ^~
      libswe/swephlib.c:4283:54: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
       4283 |         if (imod == SEMOD_JPLHORA_DEFAULT) imod = 0; break;
            |                                                      ^~~~~
      libswe/swephlib.c:4285:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
       4285 |         if (imod == SEMOD_DELTAT_DEFAULT) imod = 0; break;
            |         ^~
      libswe/swephlib.c:4285:53: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
       4285 |         if (imod == SEMOD_DELTAT_DEFAULT) imod = 0; break;
            |                                                     ^~~~~
      pyswisseph.c:58:10: fatal error: Python.h: No such file or directory
         58 | #include <Python.h>
            |          ^~~~~~~~~~
      compilation terminated.
      error: command '/usr/bin/x86_64-linux-gnu-gcc' failed with exit code 1
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for pyswisseph
  Running setup.py clean for pyswisseph
Failed to build pyswisseph
ERROR: Could not build wheels for pyswisseph, which is required to install pyproject.toml-based projects

[notice] A new release of pip is available: 23.2.1 -> 24.1.1
[notice] To update, run: /home/vvasuki/gitland/python_venv_311/bin/python -m pip install --upgrade pip

Might be forced to upgrade and fix api used.