jyotisham / jyotisha

Python tools for the astronomical / astrological vedAnga of Hindus
MIT License
92 stars 54 forks source link

Possible update to indic_transliteration_py breaking tests? #116

Closed karthikraman closed 3 years ago

karthikraman commented 3 years ago

This is a consequence of how transliterators such as ITranslator used to behave, ignoring text 'bracketed' with ##, e.g. ##xyz## will not be transliterated. Presumably, this has been removed now? Is there another way to bracket ignore text?

@vvasuki I think this is a reasonable feature like \verb"xyz" in TeX, etc. but I am sure you have a better suggestion/reason as always!

Also, is it possible to trigger builds on pushes to indic_transliterate_py? Or would that be overkill?

vvasuki commented 3 years ago

This is a consequence of how transliterators such as ITranslator used to behave, ignoring text 'bracketed' with ##, e.g. ##xyz## will not be transliterated. Presumably, this has been removed now? Is there another way to bracket ignore text?

@vvasuki I think this is a reasonable feature like \verb"xyz" in TeX, etc. but I am sure you have a better suggestion/reason as always!

Ah - the feature is still there - just removed by default. Please change invocations as shown here: https://github.com/indic-transliteration/indic_transliteration_py/blob/7c2788c4fcc51193603fec885e5c7b120099fc98/tests/sanscript/basic_test.py#L123 . Sorry about the inconvenience, but it shouldn't have been default in the first place (messes up with markdown texts) .

Also, is it possible to trigger builds on pushes to indic_transliterate_py? Or would that be overkill?

The proper way to deal with dependencies is to freeze the version we depend on - as we've done with pyswisseph.