Closed karthikraman closed 2 years ago
@vvasuki, does it make sense to rank the relative importance of festivals?
Yes!
(looks like this will vary even between people!?) Any thoughts?
Yes!
Could festivals from a given repo be automatically given a default priority configuration?
Default could be something simple and neutral like alphabetical sorting :-)
But I've created a skeleton here - https://github.com/jyotisham/jyotisha/blob/243dc5eab11e10cbbf79bedda95915eacaba0f39/jyotisha/panchaanga/writer/display_options.py#L12 . Just extend the DisplayOptions class to something like KarthikDisplayOptions. This would then be used in generation functions such as make_md() and daily_tex_writer.
Is this snippet fine? Did I get your point right?
Is this snippet fine? Did I get your point right?
Looks good but for two minor nits noted at https://github.com/jyotisham/jyotisha/commit/ccf26d9e4c98e57475a122cb38b23eecda734d29 .
Closed via c41b52f
@vvasuki, does it make sense to rank the relative importance of festivals? (looks like this will vary even between people!?) Any thoughts?
For instance, a grahaNa event may be listed first on a day, where there are multiple festivals. Temple festivals may be listed last. Could festivals from a given repo be automatically given a default priority configuration?