festival repo organisation ideas for common festivals vs. others

[karthikraman]

What would be the best way to pick select festivals for display? Our current classification is excellent (so very difficult to suggest a change) - but when it comes to many festivals/vratams, there is this notion of commonly observed vs. rarer - e.g. varalakshmi vratam vs. achalaa saptami vratam etc. Should there be a common vs. misc folder at the top level? Or, best to do it using festival tags?

[vvasuki]

No reorg for sure. Don't think that tags are a good idea either - Core fest data should be kept separate from "preferred view" - Reason is that preferences scale with users; and we wouldn't want to keep messing with fest data files.

Can just mimic https://github.com/jyotisham/jyotisha/blob/62bd10c11e29f7af9fdc6dabe665b0510b3d9fed/jyotisha/panchaanga/temporal/__init__.py#L141 and use it. Might need the following enhancements:

• Implement https://github.com/jyotisham/jyotisha/blob/62bd10c11e29f7af9fdc6dabe665b0510b3d9fed/jyotisha/panchaanga/temporal/__init__.py#L60 . Also something like fest_repos_excluded
• Dump a TOML file (in adyatithi/computation_systems?) with just the computation system for portability.

[karthikraman]

ah, so just fest_id based? makes sense.

[vvasuki]

Can just mimic

https://github.com/jyotisham/jyotisha/blob/62bd10c11e29f7af9fdc6dabe665b0510b3d9fed/jyotisha/panchaanga/temporal/__init__.py#L141

Such custom preference code is ugly - such user data should be kept separate. Did so.

   . Also something like fest_repos_excluded

* Dump a TOML file (in adyatithi/computation_systems?) with just the computation system for portability.

Implemented the above as well. (Hope https://github.com/jyotisham/jyotisha/actions/runs/4032304515 goes well. )

so just fest_id based? makes sense.

Not necessarily - could be something more structured - just the preference data should be stored separately from the core festival data.