search

jyotisham / jyotisha

Python tools for the astronomical / astrological vedAnga of Hindus
MIT License
88 stars 52 forks source link

festival rules json: No field-names with space. #18

Closed vvasuki closed 6 years ago

vvasuki commented 6 years ago

The spaces in the json field names mess up the ability of python (eg jsonpickle), js and other libraries to parse them into python/ js and other objects . Any json field name should also be a valid variable name in other programming languages. Hence, we need to get rid of those spaces in field names, for example - https://github.com/sanskrit-coders/jyotisha/blob/master/jyotisha/panchangam/data/kanchi_aradhana_rules.json Doing so will let us use such libraries to significantly simplify code.

An example in other styleguides - https://google.github.io/styleguide/jsoncstyleguide.xml#Property_Name_Guidelines

@karthikraman - You're ok with this? I suggest that we take to the "other_names" instead of "Other Names".

We'll also need to make stuff like "kAJcI 1 jagadguru zrI Adi~zaGkara bhagavatpAda ArAdhanA" values rather than field names.

karthikraman commented 6 years ago

Totally OK with the first idea. It was because I had it all in Excel and then did some CSV2JSON online.

Ok with making festival name as a value too --- I just felt keyed JSON felt cleaner to work with. Feel free to modify.

Once again, many thanks for your interest and help in making this better!

vvasuki commented 6 years ago

I've cleaned up the fields, and make description multi-lingual as well.