jyotisham / jyotisha

Python tools for the astronomical / astrological vedAnga of Hindus
MIT License
88 stars 53 forks source link

Don't make reference date a member of Interval #73

Closed vvasuki closed 3 years ago

vvasuki commented 3 years ago

A good programming principle is to strictly separate presentation (how should an interval be displayed) from the core data. That is why Interval has no timezone_id or tex stuff or that old fmt parameter, for example, as members.

However, recent commits such as https://github.com/sanskrit-coders/jyotisha/commit/8240ff5088dc90faf6541e77594ea24eb3051196 and https://github.com/sanskrit-coders/jyotisha/commit/705f1143571b51fa76898d2f536d0ab80cee9e20 do just that by including a reference date (which is purely a display contrievance). (Maybe I should have become alarmed at the suggestion in OP of https://github.com/sanskrit-coders/jyotisha/issues/69 and objected, rather than just point to the technique used for MD.)