search

jyotisham / jyotisha

Python tools for the astronomical / astrological vedAnga of Hindus
MIT License
88 stars 52 forks source link

Fix recursive submodules #74

Closed karthikraman closed 3 years ago

vvasuki commented 3 years ago

Are there recursive submodules, or do you propose adding them? If so, why do you think that the workflow would not work?

In any case, should be efficient: https://github.com/sanskrit-coders/jyotisha/issues/75

vvasuki commented 3 years ago

I see that you've moved out kAnchI-maTha directory to https://github.com/kamakoti/kanchi-matha-festivals and that it broke the builds.

There's a problem with this approach as far as upkeep of this repo is concerned - It complicates maintenance of canonical festival repositories (changing toml structure, transliterating values etc..) while also affecting our tests (with data beyond control of all maintainers/ contributors here).

So, if you really want to move out kAnchi-festivals, we should stop considering it "canonical fest repo" and remove that submodule entirely.

vvasuki commented 3 years ago

Responding to https://github.com/jyotisham/jyotisha/issues/84#issuecomment-747388581 :

Still not sure on the easiest resolution of #74. Could you clarify what you mean by periodically import? If there are structural changes, I can ensure that they are propagated back to the kamakoti repo. So keeping the structure as is works well I thought...

Existing structure does not work well because one would need to wait on you to propagate these changes (or others of that sort as in #84 ). Further, I cannot confidently do the below:

#      - name: Submodules - pull latest
#        run: git pull origin master --recurse-submodules

because - who knows - that repo may have accrued some deviation relative to tests here.

Could you clarify what you mean by periodically import?

Could be just copy pasting once in a while (possibly using a script).

karthikraman commented 3 years ago

ok, basically (semi-)manually keep it in sync with any updates. 👍