search

jyotivanjani / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Summary #6

Open sangjunp4rk opened 7 years ago

sangjunp4rk commented 7 years ago

Summary Grade: Satisfactory

Good job with your code! I really like the use of indentation and whitespace in your html code! Makes your code very easy to read! Also, good decisions on the classes and ids name. It makes it very clear what its purpose is and makes grouping your sections very effective. These organizational skills come in handy as you expand your code. Great start to the Ready program!

I included a few notes in both the html file for you to think more critically about. First, try to save your images locally instead of adding a link. Saving images adds to the stability of your website because your website is not reliant on the link to be valid all the time. Also, make sure to use the html & sign instead of just &, which is &. This is just a convention. Finally, your lines are a bit long right now. Try splitting this into new lines so it's easier to read on one screen without scrolling. Convention is usually ~79-100 characters per line.

jyotivanjani commented 7 years ago

Thank you so much for feedback and comments. I will make sure to use best practices when coding next time!