Support for passing an initial value for the prompt and a callback for the alert

jyoungblood / smoke.js

framework-agnostic styled alert system for javascript

http://smoke.js.org/

930 stars 107 forks source link

Support for passing an initial value for the prompt and a callback for the alert #20

Closed cblage closed 13 years ago

cblage commented 13 years ago

I needed these features in a project I'm working on and I thought they'd be useful for the general public:

You can pass a "value" param (along with the other options, such as the button labels) when calling smoke.prompt and the input will be pre-filled with it.
You can pass a callback as the third parameter for smoke.alert (thus, not breaking backwards-compatibility), and the callback will be called whenever the alert is closed

jyoungblood commented 13 years ago

bitchin! i'll probably change the way callbacks are done in the future so they're uniform for all functions (maybe have them all as parameters?), but these changes are tight. thank you, sir.

cblage commented 13 years ago

Yeah, it'd probably make for a cleaner and more future-proof API if you make the callbacks a regular parameter, passed along with the button labels and such. Thanks for accepting the pull request :) (By the way, I updated my profile, you can use my name instead of my username if you want - Carlos Brito Lage)