jyoungblood / smoke.js

framework-agnostic styled alert system for javascript
http://smoke.js.org/
930 stars 107 forks source link

Added support for reversing order of prompt / confirm buttons and cleaned up the code a bit #22

Closed cblage closed 12 years ago

cblage commented 12 years ago

Hey,

I needed to add support for changing the order of the prompt / confirm buttons, so I made it a param "reverseButtons", that if passed as true, will make the buttons be rendered in the opposite order.

I also cleaned up the code a bit, and made it validate with JSLint, which I think is a good way of ensuring code readability and bug-freeness.

What do you think?

-Carlos

cblage commented 12 years ago

Only mind about the last 2 commits. This first one is already on your repo, and the second one is just a merge from your repo into mine.

jyoungblood commented 12 years ago

CARLOS! i'm going to bake you a cake!

cblage commented 12 years ago

Hehe, glad you liked the changes :)

cblage commented 12 years ago

BTW, I prefer chocolate cake.

jyoungblood commented 12 years ago

woops, already made a red velvet cake. sorry...

cblage commented 12 years ago

It''s alright, any cake is good cake in my book :P