jyrcija / google-charts-on-rails

Automatically exported from code.google.com/p/google-charts-on-rails
MIT License
0 stars 0 forks source link

Multiple data sets support, legend #8

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
This patch adds support for multiple data sets.

What happens after this patch is that both in the simple and text
encodings, the numbers are scaled to the data encoding max values. It
computes the max value across multiple data sets.

Because sometimes you don't really want your chart taking up the whole
vertical range, I've added the ability to specify max_data_value -- really,
that should be named something like "max y scale" for line charts, but
maybe it's an ok name for the other types?

also, i'm still learning ruby idioms, any code prettifying would be great.
particularly in encode_data_set, there must be a cleaner way to do that.

Also added a legend display, which becomes necessary on adding more than
one data set.

Original issue reported on code.google.com by frayju...@gmail.com on 28 Feb 2008 at 8:52

Attachments:

GoogleCodeExporter commented 9 years ago
frayjusto, 
Thank you for the patch. Yes I was also thinking about a max value attribute. I 
will
look into it now. Thanks.

Original comment by bragha...@gmail.com on 29 Feb 2008 at 6:11

GoogleCodeExporter commented 9 years ago
Very good, thank you very much for the patch.

Original comment by mangelse...@gmail.com on 18 May 2012 at 7:41