1.It is quiet understandable for the Notebook file.
2.However, the python file cannot work for me. Maybe they lack of instructions for how to run the python file in Readme.
3.It is quiet good job for sprint 3. But for sprint 2, maybe lack of some work.
4.For code quality, there are some advice:
Better encapsilate each peice of code into functions or classes
No evaluation structures, after getting expected labels, models needs to pass
cetain testing frameworks i.e. unit testing, performance testing
Try to avoid nested if or for loops
Better put debugging informations with logging systems
Use multithreading to parellize training process to improve speeding
There is no error handling or exception handlings
Need description of input and output for each function
1.It is quiet understandable for the Notebook file. 2.However, the python file cannot work for me. Maybe they lack of instructions for how to run the python file in Readme. 3.It is quiet good job for sprint 3. But for sprint 2, maybe lack of some work. 4.For code quality, there are some advice: Better encapsilate each peice of code into functions or classes No evaluation structures, after getting expected labels, models needs to pass cetain testing frameworks i.e. unit testing, performance testing Try to avoid nested if or for loops Better put debugging informations with logging systems Use multithreading to parellize training process to improve speeding There is no error handling or exception handlings Need description of input and output for each function