search

jywarren / mapknitter

Use Public Lab's MapKnitter to turn your aerial images into projected maps for print and web
http://mapknitter.org
GNU General Public License v3.0
45 stars 0 forks source link

Need Loading Indicator in Web Viewer #123

Closed nickrsan closed 12 years ago

nickrsan commented 12 years ago

I have, a number of times, gone to load up maps in the web viewer, and given up because I thought it was a bug. The browser (Firefox and Chrome Latest, Win 7 Home and Pro x64) never shows a loading indicator, nor does the map, so it always looked complete...but with no image except the basemap. Today, I left it open while coming to submit a bug about image loading (knowing it must be localized to me if it wasn't already reported), and when I switched back, I discovered that it had loaded, just after a long time (I'm still on DSL).

A loading indicator will go a long way toward this. I just cloned a copy, so maybe as my first foray into the code, I'll see if I can patch one in. Don't count on it yet though. I see that it's a third party viewer, so this might be a bit much for my limited time right now.

jywarren commented 12 years ago

That would be very useful. However, we are using a fork of the "Leaflet" web viewer, running separately from MapKnitter, to display the maps. You may want to a) fork that instead (https://github.com/jywarren/plots-leaflet-viewer) and b) check the Leaflet API to see if there is already a loading notification feature -- i've never checked.

I think it's a great idea, thanks! I think I will close this issue here, however -- please feel free to open one at the above-listed plots-leaflet-viewer Github project. Thanks!!

nickrsan commented 12 years ago

Acceptable to me. migrated to https://github.com/jywarren/plots-leaflet-viewer/issues/6