search

jywarren / plots2

The Public Lab website!
http://publiclab.org
GNU General Public License v3.0
17 stars 2 forks source link

borrow github star/unstar graphics for follows and likes #112

Closed btbonval closed 11 years ago

btbonval commented 11 years ago

Github uses the same star icon, but when "unstarring", modifies the star icon with: <span class="mini-icon mini-icon-remove-star"></span>

This is probably nicer than the empty/full star notation and could also work for follows.

jywarren commented 11 years ago

but does github open source its icon sets and ui stuff? I think not... but we could add to FontAwesome...

On Thu, Apr 18, 2013 at 7:35 PM, Bryan Bonvallet notifications@github.comwrote:

Github uses the same star icon, but when "unstarring", modifies the star icon with:

This is probably nicer than the empty/full star notation and could also work for follows.

— Reply to this email directly or view it on GitHubhttps://github.com/jywarren/plots2/issues/112 .

btbonval commented 11 years ago

Look at Star/Unstar on this page and compare it to the Like on our site. Both are using the same Bootstrap iconography.

I'm assuming the little X superscripted on the star, which uses the noted class code, is also from Bootstrap.

btbonval commented 11 years ago

After doing a quick search, maybe the mini icons are not part of Bootstrap.

btbonval commented 11 years ago

GitHub does not use Bootstrap icons, it uses a font with special reserved UTF-8 characters. https://github.com/blog/1106-say-hello-to-octicons

It looks like they borrowed some things from Bootstrap / FontAwesome, but otherwise I was very much incorrect in my belief that these superscripted X's and so forth were part of Bootstrap.