jywarren / plots2

The Public Lab website!
http://publiclab.org
GNU General Public License v3.0
17 stars 2 forks source link

Universal Searchbar does not search for users #138

Closed btbonval closed 11 years ago

btbonval commented 11 years ago

I was trying to find my user page with the search bar, but users are not searched. It shouldn't be too hard to add user pages to the search results.

jywarren commented 11 years ago

Cool, did you do something on this and add "Contributors" in the sidebar? Just wondering since on some pages there are now 2 lists, one for usernames which match and one for users who've posted related material: http://publiclab.org/search/workshop

btbonval commented 11 years ago

No, I haven't touched this since making the ticket.

The sidebar would be a different thing. When you say "one for usernames which match", do you mean the searchbar returns that or the sidebar shows it? On Jun 17, 2013 9:04 AM, "Jeffrey Warren" notifications@github.com wrote:

Cool, did you do something on this and add "Contributors" in the sidebar? Just wondering since on some pages there are now 2 lists, one for usernames which match and one for users who've posted related material: http://publiclab.org/search/workshop

— Reply to this email directly or view it on GitHubhttps://github.com/jywarren/plots2/issues/138#issuecomment-19543177 .

jywarren commented 11 years ago

The sidebar shows it. Perhaps the original issue request didn't realize that a search returns users in the sidebar, not in the main search content area. If so, it's more of a matter of deciding if that's the correct way to display results and if it's clear enough.

Jeff

On Mon, Jun 17, 2013 at 12:49 PM, Bryan Bonvallet notifications@github.comwrote:

No, I haven't touched this since making the ticket.

The sidebar would be a different thing. When you say "one for usernames which match", do you mean the searchbar returns that or the sidebar shows it? On Jun 17, 2013 9:04 AM, "Jeffrey Warren" notifications@github.com wrote:

Cool, did you do something on this and add "Contributors" in the sidebar? Just wondering since on some pages there are now 2 lists, one for usernames which match and one for users who've posted related material: http://publiclab.org/search/workshop

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19543177> .

— Reply to this email directly or view it on GitHubhttps://github.com/jywarren/plots2/issues/138#issuecomment-19558012 .

btbonval commented 11 years ago

Oh, yeah that isn't obvious at all. There is nothing visually connecting the search bar to any component besides the autocomplete drop down.

Also running a proper search on the search page renders results in page center. There's no reason to look at sidebars or anywhere else on the search results page.

Maybe flash the sidebar when it updates to draw the user's attention, or simply return users with nodes as per this ticket. On Jun 17, 2013 2:26 PM, "Jeffrey Warren" notifications@github.com wrote:

The sidebar shows it. Perhaps the original issue request didn't realize that a search returns users in the sidebar, not in the main search content area. If so, it's more of a matter of deciding if that's the correct way to display results and if it's clear enough.

Jeff

On Mon, Jun 17, 2013 at 12:49 PM, Bryan Bonvallet notifications@github.comwrote:

No, I haven't touched this since making the ticket.

The sidebar would be a different thing. When you say "one for usernames which match", do you mean the searchbar returns that or the sidebar shows it? On Jun 17, 2013 9:04 AM, "Jeffrey Warren" notifications@github.com wrote:

Cool, did you do something on this and add "Contributors" in the sidebar? Just wondering since on some pages there are now 2 lists, one for usernames which match and one for users who've posted related material: http://publiclab.org/search/workshop

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19543177> .

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19558012> .

— Reply to this email directly or view it on GitHubhttps://github.com/jywarren/plots2/issues/138#issuecomment-19564289 .

jywarren commented 11 years ago

well, it only runs on proper search page as linked above (/search/foo), not on the autocomplete search (that just mixes all result types together).

I think there ought to be a top area that shows search results by type, in tabs, so the default might be "Research notes" and other tabs might show "Wiki pages" "Users" etc with counts "Users (13)".

The advanced search mixes all together, no? I don't remember.

If we restructure search results in this way, what do we do with the sidebar? Would it be empty, or show recent tags related to the search, or what? Because currently it shows wiki pages, users, and other non-note search results.

On Mon, Jun 17, 2013 at 2:29 PM, Bryan Bonvallet notifications@github.comwrote:

Oh, yeah that isn't obvious at all. There is nothing visually connecting the search bar to any component besides the autocomplete drop down.

Also running a proper search on the search page renders results in page center. There's no reason to look at sidebars or anywhere else on the search results page.

Maybe flash the sidebar when it updates to draw the user's attention, or simply return users with nodes as per this ticket. On Jun 17, 2013 2:26 PM, "Jeffrey Warren" notifications@github.com wrote:

The sidebar shows it. Perhaps the original issue request didn't realize that a search returns users in the sidebar, not in the main search content area. If so, it's more of a matter of deciding if that's the correct way to display results and if it's clear enough.

Jeff

On Mon, Jun 17, 2013 at 12:49 PM, Bryan Bonvallet notifications@github.comwrote:

No, I haven't touched this since making the ticket.

The sidebar would be a different thing. When you say "one for usernames which match", do you mean the searchbar returns that or the sidebar shows it? On Jun 17, 2013 9:04 AM, "Jeffrey Warren" notifications@github.com wrote:

Cool, did you do something on this and add "Contributors" in the sidebar? Just wondering since on some pages there are now 2 lists, one for usernames which match and one for users who've posted related material: http://publiclab.org/search/workshop

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19543177> .

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19558012> .

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19564289> .

— Reply to this email directly or view it on GitHubhttps://github.com/jywarren/plots2/issues/138#issuecomment-19564549 .

btbonval commented 11 years ago

I don't recall the autocomplete drop down returning users, but you're saying it does (albeit unsorted). I'll have to try some things out, maybe the behavior has changed since I made this ticket. On Jun 17, 2013 2:36 PM, "Jeffrey Warren" notifications@github.com wrote:

well, it only runs on proper search page as linked above (/search/foo), not on the autocomplete search (that just mixes all result types together).

I think there ought to be a top area that shows search results by type, in tabs, so the default might be "Research notes" and other tabs might show "Wiki pages" "Users" etc with counts "Users (13)".

The advanced search mixes all together, no? I don't remember.

If we restructure search results in this way, what do we do with the sidebar? Would it be empty, or show recent tags related to the search, or what? Because currently it shows wiki pages, users, and other non-note search results.

On Mon, Jun 17, 2013 at 2:29 PM, Bryan Bonvallet notifications@github.comwrote:

Oh, yeah that isn't obvious at all. There is nothing visually connecting the search bar to any component besides the autocomplete drop down.

Also running a proper search on the search page renders results in page center. There's no reason to look at sidebars or anywhere else on the search results page.

Maybe flash the sidebar when it updates to draw the user's attention, or simply return users with nodes as per this ticket. On Jun 17, 2013 2:26 PM, "Jeffrey Warren" notifications@github.com wrote:

The sidebar shows it. Perhaps the original issue request didn't realize that a search returns users in the sidebar, not in the main search content area. If so, it's more of a matter of deciding if that's the correct way to display results and if it's clear enough.

Jeff

On Mon, Jun 17, 2013 at 12:49 PM, Bryan Bonvallet notifications@github.comwrote:

No, I haven't touched this since making the ticket.

The sidebar would be a different thing. When you say "one for usernames which match", do you mean the searchbar returns that or the sidebar shows it? On Jun 17, 2013 9:04 AM, "Jeffrey Warren" notifications@github.com

wrote:

Cool, did you do something on this and add "Contributors" in the sidebar? Just wondering since on some pages there are now 2 lists, one for usernames which match and one for users who've posted related material: http://publiclab.org/search/workshop

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19543177>

.

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19558012> .

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19564289> .

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19564549> .

— Reply to this email directly or view it on GitHubhttps://github.com/jywarren/plots2/issues/138#issuecomment-19565057 .

jywarren commented 11 years ago

huh, maybe it broke? It has returned users for a couple months at least. No, i enter "btb" and i see you in autocomplete. Doesn't that work for you?

On Mon, Jun 17, 2013 at 2:38 PM, Bryan Bonvallet notifications@github.comwrote:

I don't recall the autocomplete drop down returning users, but you're saying it does (albeit unsorted). I'll have to try some things out, maybe the behavior has changed since I made this ticket. On Jun 17, 2013 2:36 PM, "Jeffrey Warren" notifications@github.com wrote:

well, it only runs on proper search page as linked above (/search/foo), not on the autocomplete search (that just mixes all result types together).

I think there ought to be a top area that shows search results by type, in tabs, so the default might be "Research notes" and other tabs might show "Wiki pages" "Users" etc with counts "Users (13)".

The advanced search mixes all together, no? I don't remember.

If we restructure search results in this way, what do we do with the sidebar? Would it be empty, or show recent tags related to the search, or what? Because currently it shows wiki pages, users, and other non-note search results.

On Mon, Jun 17, 2013 at 2:29 PM, Bryan Bonvallet notifications@github.comwrote:

Oh, yeah that isn't obvious at all. There is nothing visually connecting the search bar to any component besides the autocomplete drop down.

Also running a proper search on the search page renders results in page center. There's no reason to look at sidebars or anywhere else on the search results page.

Maybe flash the sidebar when it updates to draw the user's attention, or simply return users with nodes as per this ticket. On Jun 17, 2013 2:26 PM, "Jeffrey Warren" notifications@github.com wrote:

The sidebar shows it. Perhaps the original issue request didn't realize that a search returns users in the sidebar, not in the main search content area. If so, it's more of a matter of deciding if that's the correct way to display results and if it's clear enough.

Jeff

On Mon, Jun 17, 2013 at 12:49 PM, Bryan Bonvallet notifications@github.comwrote:

No, I haven't touched this since making the ticket.

The sidebar would be a different thing. When you say "one for usernames which match", do you mean the searchbar returns that or the sidebar shows it? On Jun 17, 2013 9:04 AM, "Jeffrey Warren" < notifications@github.com>

wrote:

Cool, did you do something on this and add "Contributors" in the sidebar? Just wondering since on some pages there are now 2 lists, one for usernames which match and one for users who've posted related material: http://publiclab.org/search/workshop

— Reply to this email directly or view it on GitHub<

https://github.com/jywarren/plots2/issues/138#issuecomment-19543177>

.

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19558012>

.

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19564289> .

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19564549> .

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19565057> .

— Reply to this email directly or view it on GitHubhttps://github.com/jywarren/plots2/issues/138#issuecomment-19565188 .

btbonval commented 11 years ago

To be specific, I was trying to find my profile on the new site.

I typed "bonval" and "btbonval" in the universal search bar but did not get a hit on my profile. I then submitted to the search page and also returned no results. The advanced search broke down the types of nodes, but "users" (specifically, user profiles) was not an option.

Might be able to search by author, but that will still only return nodes by that author, not the author's profile. On Jun 17, 2013 2:36 PM, "Jeffrey Warren" notifications@github.com wrote:

well, it only runs on proper search page as linked above (/search/foo), not on the autocomplete search (that just mixes all result types together).

I think there ought to be a top area that shows search results by type, in tabs, so the default might be "Research notes" and other tabs might show "Wiki pages" "Users" etc with counts "Users (13)".

The advanced search mixes all together, no? I don't remember.

If we restructure search results in this way, what do we do with the sidebar? Would it be empty, or show recent tags related to the search, or what? Because currently it shows wiki pages, users, and other non-note search results.

On Mon, Jun 17, 2013 at 2:29 PM, Bryan Bonvallet notifications@github.comwrote:

Oh, yeah that isn't obvious at all. There is nothing visually connecting the search bar to any component besides the autocomplete drop down.

Also running a proper search on the search page renders results in page center. There's no reason to look at sidebars or anywhere else on the search results page.

Maybe flash the sidebar when it updates to draw the user's attention, or simply return users with nodes as per this ticket. On Jun 17, 2013 2:26 PM, "Jeffrey Warren" notifications@github.com wrote:

The sidebar shows it. Perhaps the original issue request didn't realize that a search returns users in the sidebar, not in the main search content area. If so, it's more of a matter of deciding if that's the correct way to display results and if it's clear enough.

Jeff

On Mon, Jun 17, 2013 at 12:49 PM, Bryan Bonvallet notifications@github.comwrote:

No, I haven't touched this since making the ticket.

The sidebar would be a different thing. When you say "one for usernames which match", do you mean the searchbar returns that or the sidebar shows it? On Jun 17, 2013 9:04 AM, "Jeffrey Warren" notifications@github.com

wrote:

Cool, did you do something on this and add "Contributors" in the sidebar? Just wondering since on some pages there are now 2 lists, one for usernames which match and one for users who've posted related material: http://publiclab.org/search/workshop

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19543177>

.

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19558012> .

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19564289> .

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19564549> .

— Reply to this email directly or view it on GitHubhttps://github.com/jywarren/plots2/issues/138#issuecomment-19565057 .

jywarren commented 11 years ago

ah, but that quickly links you to the profile page too, no? We had also discussed simply merging the profile page with the notes-for-this-author page, perhaps again in tabs, since it's not clear which people are looking for and we might as well make the easy to switch between. Or profile could take up the first 250px of space, with recent notes falling below.

On Mon, Jun 17, 2013 at 2:41 PM, Bryan Bonvallet notifications@github.comwrote:

To be specific, I was trying to find my profile on the new site.

I typed "bonval" and "btbonval" in the universal search bar but did not get a hit on my profile. I then submitted to the search page and also returned no results. The advanced search broke down the types of nodes, but "users" (specifically, user profiles) was not an option.

Might be able to search by author, but that will still only return nodes by that author, not the author's profile. On Jun 17, 2013 2:36 PM, "Jeffrey Warren" notifications@github.com wrote:

well, it only runs on proper search page as linked above (/search/foo), not on the autocomplete search (that just mixes all result types together).

I think there ought to be a top area that shows search results by type, in tabs, so the default might be "Research notes" and other tabs might show "Wiki pages" "Users" etc with counts "Users (13)".

The advanced search mixes all together, no? I don't remember.

If we restructure search results in this way, what do we do with the sidebar? Would it be empty, or show recent tags related to the search, or what? Because currently it shows wiki pages, users, and other non-note search results.

On Mon, Jun 17, 2013 at 2:29 PM, Bryan Bonvallet notifications@github.comwrote:

Oh, yeah that isn't obvious at all. There is nothing visually connecting the search bar to any component besides the autocomplete drop down.

Also running a proper search on the search page renders results in page center. There's no reason to look at sidebars or anywhere else on the search results page.

Maybe flash the sidebar when it updates to draw the user's attention, or simply return users with nodes as per this ticket. On Jun 17, 2013 2:26 PM, "Jeffrey Warren" notifications@github.com wrote:

The sidebar shows it. Perhaps the original issue request didn't realize that a search returns users in the sidebar, not in the main search content area. If so, it's more of a matter of deciding if that's the correct way to display results and if it's clear enough.

Jeff

On Mon, Jun 17, 2013 at 12:49 PM, Bryan Bonvallet notifications@github.comwrote:

No, I haven't touched this since making the ticket.

The sidebar would be a different thing. When you say "one for usernames which match", do you mean the searchbar returns that or the sidebar shows it? On Jun 17, 2013 9:04 AM, "Jeffrey Warren" < notifications@github.com>

wrote:

Cool, did you do something on this and add "Contributors" in the sidebar? Just wondering since on some pages there are now 2 lists, one for usernames which match and one for users who've posted related material: http://publiclab.org/search/workshop

— Reply to this email directly or view it on GitHub<

https://github.com/jywarren/plots2/issues/138#issuecomment-19543177>

.

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19558012>

.

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19564289> .

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19564549> .

— Reply to this email directly or view it on GitHub< https://github.com/jywarren/plots2/issues/138#issuecomment-19565057> .

— Reply to this email directly or view it on GitHubhttps://github.com/jywarren/plots2/issues/138#issuecomment-19565377 .

btbonval commented 11 years ago

I see how it works now. I have to click "btbonval" in "Research by btbonval" to visit my profile page.

It's a two click procedure to get to my profile page, with the second step being fairly unobvious. But you're right, it is possible.

btbonval commented 11 years ago

Doesn't the user profile contain all notes and so forth that the user has authored? If so, why go to this search page instead of simply loading up the user's profile page?

jywarren commented 11 years ago

I does not - the "notes for this author" page does -- that's why we have proposed merging the pages, then we can simply load up the profile, as you say.

On Mon, Jun 17, 2013 at 2:47 PM, Bryan Bonvallet notifications@github.comwrote:

Doesn't the user profile contain all notes and so forth that the user has authored? If so, why go to this search page instead of simply loading up the user's profile page?

— Reply to this email directly or view it on GitHubhttps://github.com/jywarren/plots2/issues/138#issuecomment-19565830 .

btbonval commented 11 years ago

Got it. I guess this ticket is my way of voting for a merge. I couldn't find any ticket referring to such a merge. Is this something being decided by other folks? If not, I'll close this ticket and start a new one marking the desire to merge notes-by-author into the author's profile. If so, I'll close this ticket anyway ;)

jywarren commented 11 years ago

I think it may have been a plots-alpha discussion that never got turned into an issue? Yep, here: https://groups.google.com/forum/?fromgroups#!searchin/plots-alpha/profile$20pages/plots-alpha/_B8wEMMLBPY/N7_c9u7mhRQJ

On Mon, Jun 17, 2013 at 2:55 PM, Bryan Bonvallet notifications@github.comwrote:

Got it. I guess this ticket is my way of voting for a merge. I couldn't find any ticket referring to such a merge. Is this something being decided by other folks? If not, I'll close this ticket and start a new one marking the desire to merge notes-by-author into the author's profile. If so, I'll close this ticket anyway ;)

— Reply to this email directly or view it on GitHubhttps://github.com/jywarren/plots2/issues/138#issuecomment-19566383 .

btbonval commented 11 years ago

Looks like nobody was opposed, while yourself and Chris both commented affirmatively for the feature. I'll make a ticket.