jywarren / plots2

The Public Lab website!
http://publiclab.org
GNU General Public License v3.0
17 stars 2 forks source link

Password reset by key has case sensitive usernames #193

Closed btbonval closed 11 years ago

btbonval commented 11 years ago

A user that shall be referred to as "Username" had requested a reset.

On the reset page, http://www.publiclab.org/reset/key/somelongthing, if the username was typed in as "username", then the response was "Password change failed; key does not correspond to username." Using "Username" yielded a different result.

jywarren commented 11 years ago

I think this line has to include foo.downcase on both sides of the == to make the comparison work: https://github.com/jywarren/plots2/blob/master/app/controllers/users_controller.rb#L133

On Thu, Oct 10, 2013 at 12:30 PM, Bryan Bonvallet notifications@github.comwrote:

A user that shall be referred to as "Username" had requested a reset.

On the reset page, http://www.publiclab.org/reset/key/somelongthing, if the username was typed in as "username", then the response was "Password change failed; key does not correspond to username." Using "Username" yielded a different result.

— Reply to this email directly or view it on GitHubhttps://github.com/jywarren/plots2/issues/193 .