search

jyyulab / SJARACNe

Scalable Tool for Gene Network Reverse Engineering
Other
22 stars 16 forks source link

Update getconsensusnetwork.py to support single-directory adjmat directories #6

Closed khughitt closed 5 years ago

khughitt commented 5 years ago

This PR fixes an issue which causes getconsensusnetwork.py to fail when the filepath to the output adjacency matrices consists of only a single relative directory (e.g. getconsensusnetwork.py outputsjaracne_foo_out_/ ...).

Also did a little cleaning up to make use of Python's built-in support for filepath construction (If only support Python 3, one could also make use of pathlib).

Incidentally, in the future, it might be useful to adopt PEP8 for any Python code. The suggestions there are not that onerous to apply, but generally lead to much more readable code. Adopting similar conventions in my own work tends to make future me much happier with present me :smile_cat:.

qianchenxi1109 commented 5 years ago

Hi Khughitt,

We already have a new version of SJARACNe in master branch :) Please feel free to use the latest version. Now SJARACNe is a python package which is installable, and getconsensusnetwork.py has been updated to get_consensus_network.py. All the python scripts have been formatted using BLACK. https://github.com/ambv/black We have reviewed your changes and already approved them. Can you merge them to master branch?
Thanks!

khughitt commented 5 years ago

That's great! I submitted a new PR against the updated version of master.