This PR fixes an issue which causes getconsensusnetwork.py to fail when the filepath to the output adjacency matrices consists of only a single relative directory (e.g. getconsensusnetwork.py outputsjaracne_foo_out_/ ...).
Also did a little cleaning up to make use of Python's built-in support for filepath construction (If only support Python 3, one could also make use of pathlib).
Incidentally, in the future, it might be useful to adopt PEP8 for any Python code. The suggestions there are not that onerous to apply, but generally lead to much more readable code. Adopting similar conventions in my own work tends to make future me much happier with present me .
adamdingliang
commented
5 years ago
(Updated PR..)
This PR fixes an issue which causes
getconsensusnetwork.pyto fail when the filepath to the output adjacency matrices consists of only a single relative directory (e.g.getconsensusnetwork.py outputsjaracne_foo_out_/ ...).Also did a little cleaning up to make use of Python's built-in support for filepath construction (If only support Python 3, one could also make use of pathlib).
Incidentally, in the future, it might be useful to adopt PEP8 for any Python code. The suggestions there are not that onerous to apply, but generally lead to much more readable code. Adopting similar conventions in my own work tends to make future me much happier with present me .