jyztintan / pe

0 stars 0 forks source link

Invalid dates are accepted as valid deadlines #12

Open jyztintan opened 5 months ago

jyztintan commented 5 months ago

Certain invalid dates are able to be passed in when adding/editing the article dates. While an error should be expected, the date input validation does not seem to catch these special cases. After entering the command, the date is automatically changed into a valid date but does not match the invalid input date.

Suggestion: I think the date input validation only checks if day 31, however months without 31 days can still be input. Perhaps, could check if date is actually valid instead of checking 1<=day<=31.

image.png

Severity: Medium If left uncheck and users are unaware of this issue, this could raise confusion among users. As the dates are also being automatically modified (without any warning to user), it could cause occasional inconvenience to users, but product is still usable.

nus-pe-bot commented 5 months ago

Team's Response

This is a planned enhancement.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]