jyztintan / pe

0 stars 0 forks source link

Exit command allows additional inputs #7

Open jyztintan opened 5 months ago

jyztintan commented 5 months ago

Currently, users will still exit the application by typing exit followed by additional inputs. This could result in unintentional quitting of the application.

Calling exit add /com Tiktok /desc create new recommendation engine /status ongoing /poc jane yeo /email hr@tiktok.com /phone 9089030 /loc remote /role Software Intern where user might want to add instead of exit the application will still quit the application.

Rationale: severity.Low - This might not be ideal as the exit command might be unintentional and users have to restart the applicatio

nus-se-bot commented 5 months ago

Team's Response

This is a duplicate, as both involve extraneous parameters not being acknowledged and not having an error raised for commands without parameters like exit and clear.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Clear Command still proceeds on with invalid format

Similarly, the Clear command also proceeds with invalid input following after clear. For instance, when clear 444 is entered, the data will still be cleared.

Perhaps the team can also consider modifying the application such that clear command proceeds only when clear is entered and else an error message or warning would be provided.

Screenshot 2024-04-19 at 4.59.04 PM.png


[original: nus-cs2103-AY2324S2/pe-interim#4291] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Works as intended, because some features like help, exit, clear are intended to ignore extraneous parameters. This is a strictly documentation bug as we failed to note it down in the UG.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]