Update package.json - Githubissues

jzabala / gatsby-plugin-fontawesome-css

Gatsby plugin that disables Font Awesome auto CSS insertion and instead inserts it at compile time.

14 stars 7 forks source link

Update package.json #26

Open ed-wright opened 2 years ago

ed-wright commented 2 years ago

Update peer dependencies to solve issue #22 and allow integration with FontAwesome 6

jimappleg8 commented 2 years ago

The change that was made to the package.json file did not seem to resolve the issue. The later part of the range was removed (i.e. "^1.2.0 || ^6.1.0" changed to "^1.2.0") which I think still excludes anything past version 1.2.x of the fontawesome-svg-core file.

I'm not an expert, but I think what needs to change is either to allow higher versions of 6 (i.e. 6.2.0 is the latest)

"@fortawesome/fontawesome-svg-core": "^1.2.0 || ^6.0.0"

or just allow anything greater than 1.2.0:

"@fortawesome/fontawesome-svg-core": ">1.2.0"

I'm getting this info from here: https://github.com/npm/node-semver#versions

ed-wright commented 2 years ago

@jimappleg8 not an expert either :) im checking this now as I believe that you are mostly correct but the "@fortawesome/fontawesome-svg-core": ">1.2.0" part I am unsure about but this may be my misunderstanding.

ed-wright commented 2 years ago

@jimappleg8 i just re-checked out the code and installed via Yarn. I have also updated the package.json and lockfile using npm.

I also used https://semver.npmjs.com/ to check and the string i have seems okay although i have updated it to be more permissive. (^6.0.0 instead of ^6.1.0)