search

jzacsh / doodle

[clone of the original at https://gitlab.com/jzacsh/doodle] Yet another HTML5 webapp for drawing
https://study.j.zac.sh/doodle/
Apache License 2.0
0 stars 0 forks source link

finish npm as build-tool #1

Closed jzacsh closed 9 years ago

jzacsh commented 9 years ago

Previously this codebase was working as a manually managed HTML,js tree at commit 10884d171e2b749c135609b71bd7445e4de9766e

However, as of e3ae97cca03fed13f20c2aee390e46b1178bb25a the process to move to commonjs modules was started, but left in a broken state. Currently, somehow, running the following:

$ npm run reserve

Somehow results in angular executing after doodle_app.js - the entry point to this web app - executes. In other words, this line results in:

Uncaught TypeError: Cannot read property 'module' of undefined  app.js:11
  (anonymous function)  app.js:30
  1../doodle_page       app.js:1
  s                     app.js:1
  e                     app.js:1
  (anonymous function)  app.js:1
jzacsh commented 9 years ago

fixed by commit 1c676f21f8f233d2c214de5885784208b55d9e63