search

jzarnett / ece459

ECE 459: Programming for Performance
419 stars 133 forks source link

consistent byte ordering for VByte #74

Closed chjon closed 2 years ago

chjon commented 2 years ago

The byte ordering should be consistent between the examples. In the example for x between 2^7 and 2^14-1), the 0 control bit is on the rightmost byte, but the example for x between 2^14 and 2^21-1 had the 0 control bit on the leftmost byte.

This PR gives the 0 control bit to the rightmost byte for both examples.

patricklam commented 2 years ago

Whoops, thanks. Also fixed the written notes.

anikser commented 2 years ago

@patricklam Looks like this change isn't reflected in the compiled slides (although it is in the notes). Not sure if there is some auto-compile pipeline that wasn't triggered here.

patricklam commented 2 years ago

Sigh. It's supposed to compile automatically but doesn't always.

On Sat, Feb 26, 2022, 8:41 PM Ali Nikseresht @.***> wrote:

Looks like this change isn't reflected in the compiled slides (although it is in the notes).

— Reply to this email directly, view it on GitHub https://github.com/jzarnett/ece459/pull/74#issuecomment-1052922543, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOKE5W7BD3IUB5JRZDKGQDU5F6LNANCNFSM5NXZI5ZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you modified the open/close state.Message ID: @.***>

patricklam commented 2 years ago

Aha. It did but failed to merge.

error: failed to push some refs to 'https://github.com/jzarnett/ece459' hint: Updates were rejected because the remote contains work that you do hint: not have locally. This is usually caused by another repository pushing hint: to the same ref. You may want to first integrate the remote changes hint: (e.g., 'git pull ...') before pushing again. hint: See the 'Note about fast-forwards' in 'git push --help' for details.

I think I can fix that...

patricklam commented 2 years ago

I fixed the github action (I hope, untested) and also manually pushed the new compiled L17-slides. Thanks for following up!