search

jzbrooks / vgo

vector graphic optimization
MIT License
43 stars 2 forks source link

Comment Parsing Issues #11

Closed jzbrooks closed 4 years ago

jzbrooks commented 4 years ago

Comments cause issues writing files since they're parsed as Extra elements in the graphic. Extra elements are rendered as xml nodes in the document, which is clearly wrong for a comment.

jzbrooks commented 4 years ago

https://github.com/jzbrooks/vgo/commit/79894f9f65122b67b7a05906e64ad8384a7f5a32

For now vgo will ignore comments entirely. I'm not sure why someone would want to save comments while trying to otherwise minimize file size. We can revisit later if there's a good case for doing so.